Closed tsadpbb closed 4 months ago
ericloyd
commented
4 months ago Core has always been about being lean and functional. A lot of people use it for the monitoring but use something else for the visualization. I would have no problem relying on the older CGIs to continue to do what they do without bringing a new JS framework into play here.
sawolf
commented
4 months ago I see there is some precedent for removing older files in the html makefile. How should I handle this?
If we're already removing old files in other versions, I think it's fine to do the same for this change, as long as we're sure that we put the files there originally. After your change, there shouldn't be any way to access the reports through the interface anyways, so I don't know where the value would be in keeping the html/js around
In response to https://github.com/NagiosEnterprises/nagioscore/issues/960
There a vulnerable javascript libraries in Core in the Trends, Histogram, and Maps pages. The trends and histogram pages look identical to the CGI (legacy) pages so I don't feel bad about removing those. I do feel like removing the New Maps page will remove some usefulness out of Core but it's kind of in between a rock and a hard place.
Angular has went through a lot of changes since version 1.3.9. I believe they are on version 18 now. So we are presented with the choice of removing those pages (defaulting to the legacy CGI pages) or updating the javascript framework used in Core.
Personally, I don't think adding a bunch of fancy javascript frameworks is the right direction for core so this is my solution to the issue.
Questions
I see there is some precedent for removing older files in the html makefile. How should I handle this?