NagiosEnterprises / ncpa

Nagios Cross-Platform Agent
Other
177 stars 95 forks source link

Matrix with used psutil version for each build of NCPA #843

Open ccztux opened 2 years ago

ccztux commented 2 years ago

It would be great to have a matrix to see the used psutil version for each build of NCPA.

The requirement files: https://github.com/NagiosEnterprises/ncpa/blob/9e06ef7e0738eb7ac6f8b5a832e0a679ab3630d6/build/resources/require.dep.txt https://github.com/NagiosEnterprises/ncpa/blob/9e06ef7e0738eb7ac6f8b5a832e0a679ab3630d6/build/resources/require.txt

seems to use no version for psutil which means the latest version of psutil will be used. Maybe the psutil version should be set explicitly for each build?

On the other hand a matrix with the used psutil version per build in the https://github.com/NagiosEnterprises/ncpa/blob/9e06ef7e0738eb7ac6f8b5a832e0a679ab3630d6/README.rst is more comfortable and more accessible to several users.

Should both be used? I dont know. I am curious about the opinion of the community. :)

MrPippin66 commented 2 years ago

Franky, I'd prefer the info be included in "-V" option for "ncpa_listener" or "ncpa_passive"

jomann09 commented 2 years ago

Yeah currently we use whatever is the latest psutils during build, we could possibly add the psutils version to the output of the version command in NCPA 3 (since that's what we are working on atm)

MrPippin66 commented 2 years ago

FYI, would be nice to also include that in the "agent_version" node information.

jomann09 commented 2 years ago

That'd be easy enough I think, so we can plan on that as well

MrPippin66 commented 2 years ago

@jomann09 I can submit this as a different feature request, but would it be possible to include the openssl version, as well, since I recently discovered it looks like openssl was statically linked in the executable?

jomann09 commented 2 years ago

You don't need to open another request, when we work on this one we can also add that to the info