NagiosEnterprises / ncpa

Nagios Cross-Platform Agent
Other
176 stars 95 forks source link

Do we still need to build OpenSSL/Python on Linux/Mac? #994

Open ne-bbahn opened 9 months ago

ne-bbahn commented 9 months ago

We spent a great deal of time adjusting the installation processes on Linux/Mac/Windows to build Python with OpenSSL 3. Python 3.11+ (and maybe soon 3.8-3.10 if the MR I was looking at goes through) is now bundled with OpenSSL 3. I rewrote my custom Windows build such that it no longer downloads/builds OpenSSL or Python because it no longer needs to. Do we still need to build it on Linux and Mac?

Building OpenSSL takes three and a half eternities to build and if we don't actually need to build OpenSSL/Python anymore I think we should either:

ne-bbahn commented 9 months ago

Removing custom build stuff entirely:

+ Pros:

- Cons:

Giving the option

+ Pros:

- Cons:

As a compromise we could alter the build such that it no longer downloads/builds OpenSSL/Python, but just commenting out the old code for building OSSL/Python. I don't think we need to support Python 3.0-3.7, but there is the chance that some crazy person out there might want to try to get it to work with Windows 7 and still wants OpenSSL 3. Tbh I'm not sure if it's possible to do such a build without significant modification to the underlying libraries, but that's the only scenario I see in which it would make sense to keep the OpenSSL/Python building.