search

NagiosEnterprises / nrpe

NRPE Agent
GNU General Public License v2.0
257 stars 133 forks source link

Adding ppc64le architecture support on travis-ci #246

Closed kishorkunal-raj closed 2 years ago

kishorkunal-raj commented 3 years ago

Hi, I had added ppc64le(Linux on Power) architecture support on Travis-CI in the PR and looks like its been successfully added. I believe it is ready for the final review and merge. The Travis-CI build logs can be verified from the link below. https://travis-ci.com/github/kishorkunal-raj/nrpe

Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu.

Please have a look.

Regards, Kishor Kunal Raj

kishorkunal-raj commented 3 years ago

Any views on the PR?

sawolf commented 2 years ago

This looks fine to me - fair warning that I won't personally write any patches to fix something that breaks on powerpc. If it makes your life easier as a maintainer, though, I'm fine with having the tests run from this repository.