search

Naguissa / thanks_for_posts

Thanks for posts extension for phpBB 3.3.x and 3.2.x, compatible with Tapatalk modified sources (also available https://github.com/Naguissa/mobiquo_thanks/releases ). This extension was adapted to phpBB 3.2.x from "Thanks for posts" for phpBB 3.1 by rxu. This one, meanwhile, was forked from phpBB 3.0 MOD from Палыч. Download from here: https://github.com/Naguissa/thanks_for_posts/releases
6 stars 5 forks source link

thanks.php: Fix sizeof(): Parameter must be an array or an object tha… #3

Closed persianpros closed 4 years ago

persianpros commented 4 years ago

…t implements Countable warning

Fixes: [phpBB Debug] PHP Warning: in file [ROOT]/ext/gfksx/ThanksForPosts/notification/thanks.php on line 109: sizeof(): Parameter must be an array or an object that implements Countable

Naguissa commented 4 years ago

Yes, that fixes the warning but the problem is that notification gets empty data and therefore it fails to render correctly.

Anyway, thanks for the fix and I'll integrate when I have the main problem solved.

persianpros commented 4 years ago

Yeah that wasn't a fix, I just changed

$level = E_ALL & ~E_NOTICE & ~E_DEPRECATED;

to

$level = E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_WARNING;

in include/startup.php to silence the warnings but the thank list is empty in phpBB 3.3.0 :(