search

Naguissa / uRTCLib

Really tiny library to basic RTC functionality on Arduino. DS1307, DS3231 and DS3232 RTCs are supported.
https://www.foroelectro.net/librerias-arduino-ide-f29/rtclib-arduino-libreria-simple-y-eficaz-para-rtc-y-t95.html
GNU Lesser General Public License v3.0
87 stars 24 forks source link

1. Fix reading Alarm 1 seconds, minutes, hours (see comment) #14

Closed grepis closed 4 years ago

grepis commented 4 years ago
  1. DY/DT not set properly on refresh
  2. Disable flag not properly set during refresh
  3. Fix Alarm Modes definition - bits was not set correct
Naguissa commented 4 years ago

As I'm on holydays I was working on my tablet and something horrible happened, some changes I made were lost. I didn't add the parenthesis (I think they're not necessary, but they won't hurt) but I see last bitwise operations I modified were not in master...

Thanks for the fix!

grepis commented 4 years ago

Not a problem, have a great holidays! Without parenthesis it just doesn't work properly. And I don't have explanation why at all, tried to google for answer but nothing.

On Sat, Dec 7, 2019 at 5:59 PM Naguissa notifications@github.com wrote:

As I'm on holydays I was working on my tablet and something horrible happened, some changes I made were lost. I didn't add the parenthesis (I think they're not necessary, but they won't hurt) but I see last bitwise operations I modified were not in master...

Thanks for the fix!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Naguissa/uRTCLib/pull/14?email_source=notifications&email_token=AN6TGGL3GMLQL6FO6ROXZTTQXQTGTA5CNFSM4JXF2MFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGRLUA#issuecomment-562894288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN6TGGI76KTVMJ3TPUI5UETQXQTGTANCNFSM4JXF2MFA .

-- Best Regards, Volodymyr