Nagwa-Limited-Community / Glyphs-MATH-Plugin

11 stars 1 forks source link

Editing failed bug #24

Open juliusross1 opened 2 weeks ago

juliusross1 commented 2 weeks ago
Screenshot 2024-06-30 at 12 58 11 PM

Was editing the math variants, and got this message (which appears now each time that I click Gylph -> Edit Math Variants.

Let me know if there is more information I can provide.

khaledhosny commented 2 weeks ago

This probably means you entered a name of a non-existent glyph. I don’t have an immediate fix, other than editing the file in a text editor and removing the offending glyph name.

If you can share the file with me, I might try to make the plugin code more resilient in such cases, but I’m rather occupied with other stuff right now so that might take a while.

juliusross1 commented 1 week ago

Thanks, I fixed it already my file the way you suggested.

I will try and create a file that causes this bug in case it is helpful to you to do the fix.

I understand you are busy - thanks for the great plugin it is exactly what I need (I am trying to make a variable math font). If I get time myself I may send you a patch for a small improvement that I hope you are willing to consider.

Julius

‪On Tue, Jul 2, 2024 at 6:01 AM ‫خالد حسني (Khaled Hosny)‬‎ < @.***> wrote:‬

This probably means you entered a name of a non-existent glyph. I don’t have an immediate fix, other than editing the file in a text editor and removing the offending glyph name.

If you can share the file with me, I might try to make the plugin code more resilient in such cases, but I’m rather occupied with other stuff right now so that might take a while.

— Reply to this email directly, view it on GitHub https://github.com/Nagwa-Limited-Community/Glyphs-MATH-Plugin/issues/24#issuecomment-2202748870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE66RL4TWXTCK3S6LTKQ7SDZKKCCBAVCNFSM6AAAAABKEJIPEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBSG42DQOBXGA . You are receiving this because you authored the thread.Message ID: @.*** com>

khaledhosny commented 1 week ago

If I get time myself I may send you a patch for a small improvement that I hope you are willing to consider.

Sure, that would be very appreciated.

juliusross1 commented 1 week ago

Here is a minimal example that shows the bug that I think is related to the bug above

Open Gylphs3 New File -> Latin ->Create File Add Gylphs -> "dblIntegral" ->Generate Gylph -> Edit Math Variants In Variants type "dblIntegral" and press enter File -> Export. (I did not change anything here so am exporting OTF/Postscript/CFF") The export fails and the error is attached.

What is strange is that if I do the same but with "A" instead of "dblIntegral" it all works fine.

Screenshot 2024-07-04 at 3 25 46 PM
juliusross1 commented 1 week ago

I think bug is being caused by the "Production name" in the gylph not being correctly set.