search

NagyD / SDLPoP

An open-source port of Prince of Persia, based on the disassembly of the DOS version.
GNU General Public License v3.0
1.1k stars 140 forks source link

Provide icon and .desktop file #103

Open ghost opened 7 years ago

ghost commented 7 years ago

Would be nice if you could add an application icon and a .desktop file. For example

[Desktop Entry]
Encoding=UTF-8
Name=SDLPoP
Comment=An open-source port of Prince of Persia
StartupNotify=false
Exec=prince
Icon=prince.png
Terminal=false
Type=Application
Categories=Application;Game;ArcadeGame;
NagyD commented 7 years ago

The icon is done: 6e325cd3ac11d5338ea4a1189641b849d4b5450d

ghost commented 7 years ago

Thanks!

Falcury commented 7 years ago

I have set the icon for the build process using CMakeLists.txt here: #116

NagyD commented 7 years ago

Here is my first attempt at a .desktop file, on a separate branch: 95dc47c1d15f3c1fb2f681f5d6e5cd1118faf1c7

The Linux desktop manager I'm currently using can't put files onto the desktop, so make install will place the .desktop file into the applications menu.

Please tell me what you think.

ghost commented 7 years ago

Thank you!

/usr/share/applications is the default location for .desktop files, so I think it should be installed there. :)

It would be great (and make packagers life easier) if SDLPoP could be build to use (and installed to) the standard locations.

PREFIX/bin/prince for the executable PREFIX/share/SDLPoP for the data /home/<username>/.SDLPoP for savegames etc.

Where PREFIX is by default /usr/local but can be changed with the call to make. For example: make PREFIX=/usr install

Just a suggestion, but would be great. :)

ftoledo commented 3 years ago

Thank you!

/usr/share/applications is the default location for .desktop files, so I think it should be installed there. :)

It would be great (and make packagers life easier) if SDLPoP could be build to use (and installed to) the standard locations.

PREFIX/bin/prince for the executable PREFIX/share/SDLPoP for the data /home/<username>/.SDLPoP for savegames etc.

Where PREFIX is by default /usr/local but can be changed with the call to make. For example: make PREFIX=/usr install

Just a suggestion, but would be great. :)

I second this. I working on deb package for Huayra GNU/Linux (Debian based). https://github.com/HuayraLinux/pkg-sdlpop/

The .desktop template generation also is not working fair because building using debian pbuilder, let the $ROOT as /tmp/buildd/package-name-xxxx/ and it create wrong path for the executable. I think that honnor PREFIX variable will solve the issues.

Thanks!