NagyD / SDLPoP

An open-source port of Prince of Persia, based on the disassembly of the DOS version.
GNU General Public License v3.0
1.1k stars 141 forks source link

Provide an AppImage for Linux #193

Open probonopd opened 5 years ago

probonopd commented 5 years ago

Providing an AppImage would have, among others, these advantages:

Here is an overview of projects that are already distributing upstream-provided, official AppImages.

If you have questions, AppImage developers are on #AppImage on irc.freenode.net.

probonopd commented 5 years ago

I have made an AppImage but it is trying to load data files from non-existent locations; more investigation needed.

Work done so far: https://github.com/probonopd/SDLPoP/blob/patch-1/.travis.yml

Edit: Turns out that the code is making heavy use of g_argv[0] rather than /proc/self/exe:

https://github.com/NagyD/SDLPoP/search?q=g_argv%5B0%5D&unscoped_q=g_argv%5B0%5D

Will work around that by cd'ing there before executing.

EndeavourAccuracy commented 5 years ago

There's already a Snap (page, thread), there's already a request for a Flatpak, and now this issue discusses the creation of an AppImage. Then, of course, we could still ask for a DEB and an RPM. Linux is such a BS OS.

probonopd commented 5 years ago

Choice is good. The other options don't give a single file that can just be downloaded, moved around, and executed.

probonopd commented 5 years ago

An AppImage can be downloaded for testing:

https://github.com/probonopd/SDLPoP/releases/tag/continuous

Just download, set the executable bit, and run.

Feedback highly welcome.

johnledezma34 commented 2 years ago

I tested it in my steam deck using a app image importing app to do so. It works great! Just one issue, I can’t seem to save at all. I got a message on the bottom about quicksave being disabled i think?

dellmonitor commented 1 year ago

SDLPoP creates save alongside binary. AppImages provides read-only directory with binary and data so you aren’t able to save.