NagyD / SDLPoP

An open-source port of Prince of Persia, based on the disassembly of the DOS version.
GNU General Public License v3.0
1.1k stars 141 forks source link

Fix linker error when building with newer clang #203

Closed thrimbor closed 4 years ago

thrimbor commented 4 years ago

The master branch of LLVM has a change that makes -fno-common a default for clang. This causes symbols with multiple definitions to become hard errors, which makes SDLPoP fail to link.

This PR fixes it by removing those second definitions - all removed symbols were already defined in data.c. It shouldn't introduce any behavioral changes, and I didn't notice any when I did a few minutes of gameplay testing.