search

NagyD / SDLPoP

An open-source port of Prince of Persia, based on the disassembly of the DOS version.
GNU General Public License v3.0
1.1k stars 141 forks source link

Separating replay saving and its dialog into two distinct functions #240

Closed SergioMartin86 closed 3 years ago

SergioMartin86 commented 3 years ago

Separating replay saving and its dialog into two distinct functions

This is so that I can call the saving function without having the dialog shown. No other changes made.

NagyD commented 3 years ago

I see you (accidentally?) changed the indentation of the involved functions. I'd prefer if you changed it back so that the "Files changed" tab showed only what you actually changed. Thank you in advance.

SergioMartin86 commented 3 years ago

Hi David,

I believe I solved it now :) Thank you

(have you considered using clang-format or similar tool to automatize styling?, here's an example from one of my repos https://github.com/cselab/korali/blob/master/.clang-format)

NagyD commented 3 years ago

It's better now, but the part in the new save_recorded_replay function still has a different indentation from the original. Please look at the "Files changed" tab.

Also, did you add the overflow fix to this pull request by mistake?

SergioMartin86 commented 3 years ago

Yes, I mixed things up by accident. Let me fix this up.