search

NagyD / SDLPoP

An open-source port of Prince of Persia, based on the disassembly of the DOS version.
GNU General Public License v3.0
1.1k stars 141 forks source link

Can't "careful step" with joysticks not compatible with SDL_GameController #273

Closed lorsanta closed 2 years ago

lorsanta commented 2 years ago

I think that the bug is caused by this line: https://github.com/NagyD/SDLPoP/blob/211796b7a905028b6c1583bb6c78014bfaa385a0/src/seg009.c#L3509 Instead of joy_X_button_state = -1; we should have joy_X_button_state = 1; as it is done here: https://github.com/NagyD/SDLPoP/blob/211796b7a905028b6c1583bb6c78014bfaa385a0/src/seg009.c#L3448

NagyD commented 2 years ago

Done: ed7246a5b836627a85f61b7e0f5fac1d8ff1870a

You wrote "I think". Can you verify if this change indeed fixes the bug?

lorsanta commented 2 years ago

Yes it does, I just double-checked now.