search

Nain57 / Smart-AutoClicker

An open-source auto clicker on images for Android
GNU General Public License v3.0
2.06k stars 362 forks source link

"Absent" toggle doesn't work #551

Closed vsalustiano-st closed 3 days ago

vsalustiano-st commented 3 days ago

Version of Smart AutoClicker

3.1.0-beta01 but I tried 3.0.6 as well

Apk

Github

Device brand and model

Poco F5 Pro

Version of your Android OS

14

Type

Smart scenario

Describe what happened?

I started with a simple script that clicks on a button when an image is found on the screen. When I test this condition, I can see a green border around the scanned area, indicating that the match was a success. So far so good.

My problem is with doing the opposite: clicking on a button when an image is NOT FOUND. I tried the "Absent" toggle, but it just doesn't work. When I test this condition, the border on the scanned area remains red, regardless if the image is found or not. I don't know much yet, but I think something else is causing conditions to never match in case the "Absent" toggle is on.

Describe what should have happened?

I would expect the border on the scanned area to become green and execute the linked actions in case the image is not found.

Nain57 commented 3 days ago

Hi and thank you for your feedback.

I made some manual tests, and I have added a test case for this specific use case (https://github.com/Nain57/Smart-AutoClicker/commit/5828dd3c65bd14669d730c69dc132ec61cb66377), everything is working as intended.

I thinks this comes from a misunderstanding due to the UI. When testing an ImageCondition, the rectangle color is indicating if the condition image is detected on the screen, and not the fulfillment state of the condition itself. This means changing the value to absent wil not change the color of the rectangle during the testing, as it is still detected. But during normal execution, everything will behave as you expect.

This is more a minor UI issue, i have updated it to reflect the fulfillment state instead of the detection, so it will be red in your use case.

Not a bug but UI change: Accepted (https://github.com/Nain57/Smart-AutoClicker/commit/3dcacea3dbc03d395745af05dc2228ea2ff9efe1). This can be misleading for new users, and it will provide a visual feedback for this feature. Moving from: Capture d'écran 2024-11-23 150903

To: Capture d'écran 2024-11-23 150923

Nain57 commented 3 days ago

Should be fixed on 3.0.1-beta02, available as soon as the build is completed. https://github.com/Nain57/Smart-AutoClicker/releases/tag/3.1.0-beta02

If you still encounter the issue, feel free to repoen this ticket.

vsalustiano-st commented 3 days ago

Thanks! The app is awesome once we get the hang of it. 😊