Naissant / dendri

Common Healthcare feature engineering algorithms implemented in PySpark.
MIT License
2 stars 1 forks source link

Add retain_shape option to condense_segments #11

Closed jenjentran closed 3 years ago

rileyschack commented 3 years ago

@jennylovesreading I'd prefer a solution without joining back to the original dataframe. I suppose the issue is that the date columns get replaced with the "condensed" values.

jenjentran commented 3 years ago

@rileyschack Just a clarification but

  1. Return the original DataFrame, with 2 additional columns for start/end dates

means that the original as well as the condensed dates are present.

rileyschack commented 3 years ago

@jennylovesreading That's correct

rileyschack commented 3 years ago

@jennylovesreading Looks like the code needs to be formatted with black.

WesRoach commented 3 years ago

Thanks for working on this @jennylovesreading!