search

Nakiami / mellivora

Mellivora is a CTF engine written in PHP
GNU General Public License v3.0
440 stars 171 forks source link

Fix two bugs relating to non-competitors #128

Open rkevin-arch opened 4 years ago

rkevin-arch commented 4 years ago

Fix the two following bugs:

  1. If a non-competitor solved a challenge before a competitor did, the competitor's profile page will list them as 2nd to solve the challenge even when they're the first competitor to do so. The scoreboard displays the first solver correctly. Here's me registering a non-competitor account, solving a challenge, registering a competitor account and solve the same challenge: image

  2. If a non-competitor solved a challenge, the scores page will include them when calculating the "solved by" percentage, as shown below: image

rkevin-arch commented 4 years ago

Fix a third issue related to non-competitors. Similar to the first issue, if a non-competitor solves a challenge, they are taken into account when calculating the solve position on the challenges page.