NamPNQ / bower-videogular-youtube

Videogular `youtube` plugin repository for distribution on `bower`
MIT License
41 stars 32 forks source link

Clicking VIdeo to Play/Pause doesn't trigger an event #30

Closed keckelt closed 9 years ago

keckelt commented 9 years ago

Hi, playing or pausing the video by simply clicking on it doesn't trigger a state change event.

my Videogular HTML looks like this:

<videogular vg-player-ready="controller.onPlayerReady($API)"  vg-update-time="controller.onUpdateTime($currentTime, $duration)" vg-update-state="controller.onUpdateState($state)" vg-complete="controller.onCompleteVideo()" vg-theme="controller.config.theme">
  <vg-media vg-youtube="rel=1;showinfo=1" vg-src="controller.config.sources"></vg-media>
</videogular>

and the controller's onComplete function is just:

controller.onCompleteVideo = function() {
  console.log("onCompleteVideo");
};
arminhammer commented 9 years ago

I just tested this out and I can confirm that it works. I now have onCompleteVideo() executed after the video is done playing. I recommend merging this fix.

NamPNQ commented 9 years ago

@keckelt can you help me for continue maintaince this project, i don't have time for this.

keckelt commented 9 years ago

I'm currently working on my first angularjs application, so I only have little knowledge here and none about bower and so on. I guess it's best if I just continue to create pull request when I discover any issues(?).

Best, Klaus Am 12.03.2015 06:33 schrieb "Phạm Ngọc Quang Nam" <notifications@github.com

:

@keckelt https://github.com/keckelt can you help me for continue maintaince this project, i don't have time for this.

— Reply to this email directly or view it on GitHub https://github.com/NamPNQ/bower-videogular-youtube/issues/30#issuecomment-78426468 .

NamPNQ commented 9 years ago

ok, tks you :dancer: