Broadcasting Youtube Player event

[JenjisKhan]

These changes add the broadcasting of 2 events:

• _ytVideoReady_ - fired when the onVideoReady is completed;
• _ytVideoStateChange_ - fired when an onVideoStateChange event occurs on a player. The landing state of the player could be retrieved from the broadcasted data.

[Elecash]

$broadcast is not good for performance reasons, you should change it to $emit.

Additionally, it would be desirable to not use events. Instead of, I suggest you to use scope callbacks defined in this way on your DDO:

scope: {
    vgVideoReady: '&',
    vgVideoStateChange: '&'
}

That allow you to subscribe to a callback and you don't need to send events, which should be avoided always it's possible in AngularJS.

[JenjisKhan]

I'll change $broadcasting in $emit, but i can not declare an isolated scope in the directive, 'cause the needed vgSrc already has an isolated scope in DDO... ... ...right? (i'm not so skilled in angular!)

Just to get the point: you mean to share the vgVideoReady and vgVideoStateChange so in controller you can $watch the value and fire a callback when needed, don't you?

Thank you!

[Elecash]

Oh! Yes, you're right!

This is declared as an attribute inside vg-media which already haves an isolated scope and therefore we will have a scope collision.

What I pretend is to pass a function reference (or callback) and call it from vg-youtube. In Angular world that's usually a better scenario than events.

BTW, I corrected the code in my previous comment, I put @ when I want to put &.

[JenjisKhan]

Ok, I'll fix $emit so i can request a new pull in soon. It's ok?

Thank you very much @Elecash!

[Elecash]

Sure, that's perfect :smile:

[2fdevs]

Closing.

Reopen when you have this fixed and up-to-date.