search

NamTThai / PokemonShowdownAndroidClient

Other
44 stars 14 forks source link

Damage Calculator #44

Closed Lazloz closed 9 years ago

Lazloz commented 9 years ago

The same calculator with some little fixes. Also implemented the suggestions.

NamTThai commented 9 years ago

U did an insane amount of works in a week I'm impressed

NamTThai commented 9 years ago

Do we support stat changes? Like Atk +1 +2 etc.

Lazloz commented 9 years ago

Currently not as the ui doesn't support it, but it is on the agenda. Just like Status Conditions, modifiable health, item support and a button to enforce crit calculation.

NamTThai commented 9 years ago

Great! For now stats change is the only critical thing to be done. Afterwards, you have options to either finishing dmg_calc, or temporarily move to a different project for a change. Your choice :)

CLEMENTINATOR commented 9 years ago

I do agree with him, that's an insane amount of stuff done! Gratz and thx On 28 Nov 2014 20:25, "Nam Thai" notifications@github.com wrote:

U did an insane amount of works in a week I'm impressed

— Reply to this email directly or view it on GitHub https://github.com/NamTThai/PokemonShowdownAndroidClient/pull/44#issuecomment-64923063 .

Lazloz commented 9 years ago

Where would you like to have the the option for stat changes? Directly at the IV, DV dialog (I would extend it so it doesn't mess with other views e.g. teambuilder)?

NamTThai commented 9 years ago

That works too. Just pass in a REQUEST for Stat changes during fragment creation. If true then options for stat changes are VISIBLE. Otherwise, set it to GONE

Lazloz commented 9 years ago

The stat changes are implemented now. Something else that is a critical thing?

NamTThai commented 9 years ago

Yes I have a mini-project that I am working on, but Im busy with classes lately so I would definitely appreciate a hand.

BattleFragment holds 2 ArrayList, which holds information of each pokemon in each team, including revealed moves, revealed items, revealed ability etc., as the battle progresses. The goal is that whenever user clicks on a pokemon (or an icon on the panel), a PokemonInfoFragment will display with all of these information.

BattleMessage holds processor for all battle logs from Showdown server. What I am doing now is that whenever things are revealed, they get added to the PokemonInfo of appropriate Pkm. (e.g. when we get notification that p1a:Azumarill uses Waterfall, the PokemonInfo object of Azumarill has its move list updated.

Do you wanna work on this?

Lazloz commented 9 years ago

Sorry, was pretty tired yesterday, so I couldn't answer. Yes, I will look into it today, but it will probably take some time to get some messages. This should probably work with abilities too. Shall I put the possible abilities (until the real one gets revealed) in the PokemonInfo as well?

NamTThai commented 9 years ago

I believe I had that. I try to include everything possible, including remaining PP

NamTThai commented 9 years ago

I havent put onClickListener on sprites and icon btw