search

NamTThai / PokemonShowdownAndroidClient

Other
44 stars 14 forks source link

Set Up For Replays #49

Closed Mimerme closed 9 years ago

Mimerme commented 9 years ago
Mimerme commented 9 years ago

Had to do some modifications to work with latest android studio. Seemed a bit weird, maybe you can help me with it.

CLEMENTINATOR commented 9 years ago

I'm using android studio beta 0.8.14 (lastest stable version). What version are you on?

NamTThai commented 9 years ago

Here is coding guidelines fyi https://source.android.com/source/code-style.html

NamTThai commented 9 years ago

I and TeToNN will mostly be nitpicking for the first few rounds of comments so plz stay with us. We'll make higher level comments when the code is clean and easy to read by Java standard

NamTThai commented 9 years ago

Overall I gotta say that I'm not comfortable with using Jsoup. I prefer native Android elements, to take advantage of Google's optimization. I'll wait and see if your implementation can be nice and smooth, but for the time being, I'm leaning toward no.

Mimerme commented 9 years ago

This was much more of a place holder application of getting the replay and such. I have plans to make the actual replay fragment much "prettier". As for Jsoup I agree, but for now I'm too lazy to do anything about it because I've been pretty busy. And as well thanks for the tips!

PS: I'm using Android Studio 1.0.0 ,i think...

Lazloz commented 9 years ago

Had the same problem with Android Studio 1.0 RC1. Try to change the dependencies in the top-level build.gradle to

dependencies {
      classpath 'com.android.tools.build:gradle:0.14.2'
}

That helped me.

NamTThai commented 9 years ago

Why do you guys need Android Studio 1.0? It's unstable as far as I know. Anyway, about pull requests, each PR should be on a different topic. So far I have been lenient but probably not in this case. Changes made to build.gradle have to be on a different PR.

@Mimerme as for placeholder, feel free to do whatever you want in your forked repository. Only finished features will be merged.

CLEMENTINATOR commented 9 years ago

Seems like android studio has officially updated to 1.0 (stable)

NamTThai commented 9 years ago

Awesome I saw the update. I'll look into updating gradle.build

CLEMENTINATOR commented 9 years ago

Just need higher version on gradle plugin and switch runproguard (deprecated) to minifyenabled On 9 Dec 2014 22:48, "Nam Thai" notifications@github.com wrote:

Awesome I saw the update. I'll look into updating gradle.build

— Reply to this email directly or view it on GitHub https://github.com/NamTThai/PokemonShowdownAndroidClient/pull/49#issuecomment-66364200 .

NamTThai commented 9 years ago

Can u put in a PR for that plz?

CLEMENTINATOR commented 9 years ago

Will have to wait tommorow morning! On 9 Dec 2014 22:52, "Nam Thai" notifications@github.com wrote:

Can u put in a PR for that plz?

— Reply to this email directly or view it on GitHub https://github.com/NamTThai/PokemonShowdownAndroidClient/pull/49#issuecomment-66364912 .

NamTThai commented 9 years ago

Sounds good!