Basic Replay Support

[Mimerme]

TODO : Allow user to view their own replays Create a better front end Download and watch local replays Make code prettier?

Any criticism would be greatly appreciated, thanks!

[NamTThai]

@Mimerme hey tks for the PR. Im in the middle of something; I'll take a look as soon as I can

[CLEMENTINATOR]

it's really hard reviewing this since it seems like you didnt merge upstream/master correctly.

I can see commis made by me while it shouldnt happen

[Mimerme]

@TeToNN New to contributing code with git, so what does it exactly mean that I didn't merge the branches correctly? What should it be instead?

[CLEMENTINATOR]

Like usually you want to:

• fetch upstream/master
• merge it with your master branch
• do your work in master (not recommended) or in a new branch (recommanded)
• commit your stuff
• fetch upstream and merge again and commit

So on a pull request it shows your commits only and something like Merge remote-tracking branch 'upstream/master' into xxx.

Not sure what Nam thinks about it though

[NamTThai]

Yeah that sounds good

[Mimerme]

Ah ok, thank you for the help TeToNN