search

NamVr / DiscordBot-Template

A boilerplate / template for discord.js v14 bots with 100% coverage of Discord API, command handler, error handler based on https://discordjs.guide/
https://djs.docs.namanvrati.me/
Apache License 2.0
322 stars 75 forks source link

Better help slash command + some other improvements #13

Closed GoudronViande24 closed 2 years ago

GoudronViande24 commented 2 years ago

See #11

See commits for more details, but here is the summary:

I did some testing so it should be safe to implement this.

Happy to contribute to this project, it helped me a lot to learn about the new stuff of Discord.js v13!

NamVr commented 2 years ago

Hey can you reverse the license changes? I thought I did the license stuff good earlier

NamVr commented 2 years ago

Overall it looks good. Just the license commit I felt unnecessary. Thank you so much for the contribution.

GoudronViande24 commented 2 years ago

I did not change the license, only made it clearer. You say in the readme that it's licensed under ISC, but you did not have the license file. I just added the file. Without it, it's like if the project was not open source and people are not allowed to use it...

NamVr commented 2 years ago

Oh, alright thanks for PR I'll make a little change and merge it.

NamVr commented 2 years ago

@GoudronViande24 I need access to contribute to the PR.

NamVr commented 2 years ago

Hi?

Mioultigaming commented 2 years ago

Problem fix ?

GoudronViande24 commented 2 years ago

Sorry, I did not get the notification 2 days ago.

I give you access right now.

GoudronViande24 commented 2 years ago

What changes did you want to make?

Mioultigaming commented 2 years ago

12 <- Can anyone help me with this problem please? -> #12

NamVr commented 2 years ago

Sorry, I did not get the notification 2 days ago.

I give you access right now.

I still don't have access

GoudronViande24 commented 2 years ago

Sorry, I did not get the notification 2 days ago.

I give you access right now.

I still don't have access

I gave rights to all maintainers of this repo

If you can't make a commit, just make a pr to my fork it also works.

GoudronViande24 commented 2 years ago

Any updates about this? @NamVr

NamVr commented 2 years ago

Today for sure, sorry for the delays.

NamVr commented 2 years ago

Thank you so much @GoudronViande24! If you would like to stay in touch with me, please add me on discord @ allroundernaman#3915 or https://discord.gg/N7AJFYf8EP (Support Server). :heart:

GoudronViande24 commented 2 years ago

Wait I just saw you merged only one commit. You should merge the entire pull request since there are some other improvements.

GoudronViande24 commented 2 years ago

I will make another pull request so it's easier for you