search

NamanShergill / diohub

An open-source unofficial GitHub mobile client, that aims to deliver the ultimate GitHub experience on mobile devices.
https://github.com/NamanShergill/diohub
GNU General Public License v3.0
735 stars 25 forks source link

Preview Pictures Instead of URL #166

Open D-Maxwell opened 3 weeks ago

D-Maxwell commented 3 weeks ago

whenever one taps on an image asset, they are currently given its URL.

there are two caveats with this.

first off, the field displaying this URL does not allow for text selection ; so there effectively is no native way to copy it.

secondly, it poses a UX issue, in that this is both unexpected and undesirable behaviour. upon clicking on such an asset, one expects for the ability to zoom into a fully width copy of it.

note that this last point not being true would have been fine as a workaround —had we had the ability to actually make use of said link to begin with.

NamanShergill commented 3 weeks ago

The part of the link being unusable, should be fixed in the new version, as it has context menus for these things.

You’re right about the expected behaviour being that it takes the focus on being tapped on, with the context menu for the link being the long press behaviour. Thanks for the feedback.