search

Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
33 stars 85 forks source link

Add spinner #101

Closed Namanl2001 closed 3 years ago

Namanl2001 commented 3 years ago

Describe the feature you'd like to be added A spinner/loader gif could be added in place of initializing data here.

DineshKoushik commented 3 years ago

Hi @Namanl2001 , Let me take over this issue. I guess, I can help you with this.

DineshKoushik commented 3 years ago

@Namanl2001 Hi again, please verify the pull request I created, go through the updates made. If possible give feedback as well, if I missed out something. Thank you.

Muditxofficial commented 3 years ago

@Namanl2001 Can i work on this issue

Muditxofficial commented 3 years ago

@Namanl2001 bootstrap-4-react does not have inbuilt spinner,should i create from css or use their progress components which looks like this. progress

Namanl2001 commented 3 years ago

@Namanl2001 bootstrap-4-react does not have inbuilt spinner,should i create from css or use their progress components which looks like this. progress

Sure you can use this but decrease the width to make it more attractive and also if you like you can add some heading above the bar saying "initializing data".

Muditxofficial commented 3 years ago

Screenshot from 2021-04-12 09-29-10

Changes made per request.

Namanl2001 commented 3 years ago

Nice please make a PR. But don't forget to customize it for the mobile phone too. Also, add screenshots from both laptop and mobile after final changes.