Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
33 stars 85 forks source link

Name filter #136

Closed ChitvanRamani22 closed 3 years ago

ChitvanRamani22 commented 3 years ago

Related Issue

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

Give a clear description what modifications you have made

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

Additional Info (optional)

Any additional information you want to give

ChitvanRamani22 commented 3 years ago

@Namanl2001 please have a look at this pr. It solves the issue https://github.com/Namanl2001/MERN-Gurujii-dev/issues/10

ChitvanRamani22 commented 3 years ago

@Namanl2001 The screenshots for laptop-view and mobile-view are attached below:

laptop-view mobile-view

Namanl2001 commented 3 years ago

In mobile, it is looking cool but on pc, I guess moving filters side by side would be nice. WDYT?

ChitvanRamani22 commented 3 years ago

@Namanl2001 does this looks fine?

Screenshot (475) Screenshot (476)

Namanl2001 commented 3 years ago

@Namanl2001 does this looks fine?

Yep! fine

Namanl2001 commented 3 years ago

@ChitvanRamani22 why have made a new pr for these changes? What about this pr then?

ChitvanRamani22 commented 3 years ago

@Namanl2001 i am.closing this.