search

Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
33 stars 85 forks source link

Add another filter which filters between "Home Tutor" and "External Tutor" #139

Closed tend2infinity closed 3 years ago

tend2infinity commented 3 years ago

Describe the feature you'd like to add We already have filters related to the subject and class but maybe some students want to sort the tutors based upon Home or External Tutor. I want to add this functionality by creating another filter just like the previous ones.

Describe how you will do it There's a reducer in this application so I will create another case for the reducer in which I can update the global state by filtering only those tutors in the global state that matches with the filter

Namanl2001 commented 3 years ago

Already there #111 If no one is on that issue then feel free to take it up. Thanks!

akshay1027 commented 3 years ago

@tend2infinity I have already made a PR for this, but am unable to combine the subject filter and home/external tutor filter! check this video for more info https://drive.google.com/file/d/1GrkY-KRc_zjPyCCKfSRp_DXjJHKdWcmP/view?usp=sharing. Here is my PR #122, if you can solve this problem, please do it! i would be grateful for that