Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
33 stars 85 forks source link

404 page added #159

Closed Ankita297 closed 3 years ago

Ankita297 commented 3 years ago

Related Issue

404 page added Closes: #3

Describe the changes you've made

I have added the 404 page

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

Additional Info (optional)

Any additional information you want to give Gurujii com - Google Chrome 22-04-2021 19_47_41

Gurujii com - Google Chrome 22-04-2021 19_47_57

Ankita297 commented 3 years ago

@sagar-barapatre @Namanl2001 Please review my PR .

Ankita297 commented 3 years ago

Sir i have added the Navbar separtely on both pages because homepage needed parallax effect and 404 page does not need it . But as we use Navbar on app.js it will be render on both page .

sagar-barapatre commented 3 years ago

Okay this looks fine to me.

Ankita297 commented 3 years ago

@sagar-barapatre According to me its okay but if you want we can change it .

Ankita297 commented 3 years ago

@sagar-barapatre please tell what change do you want ?

sagar-barapatre commented 3 years ago

I was thinking of something like "Oops, the page you're looking for doesn't exists".

Ankita297 commented 3 years ago

Home_external tutor by akshay1027 · Pull Request #122 · Namanl2001_MERN-Gurujii-dev - Google Chrome 23-04-2021 19_00_29

@Namanl2001 @sagar-barapatre is it okay now ?

Ankita297 commented 3 years ago

Gurujii com - Google Chrome 24-04-2021 10_26_14

Ankita297 commented 3 years ago

@Namanl2001 @sagar-barapatre Please review it now .

Ankita297 commented 3 years ago

@Namanl2001 @sagar-barapatre any other changes required ? The mobile view is fine .

Ankita297 commented 3 years ago

@Namanl2001 is it okay now ?

Ankita297 commented 3 years ago

https://user-images.githubusercontent.com/67833077/116275682-79cd4100-a7a1-11eb-97a8-1c8339db4682.mp4

@sagar-barapatre @Namanl2001 is it okay now ?

Namanl2001 commented 3 years ago

In the video attached I'm able to see 1st and 2nd point implemented but what about 3rd point mentioned above?

Ankita297 commented 3 years ago

@Namanl2001 Sir i have not changed the part related to filter .

Ankita297 commented 3 years ago

Thus the part of filter is shown when data intialized is complete ? Gurujii com - Google Chrome 27-04-2021 22_06_38

Namanl2001 commented 3 years ago

I guess you haven't setup the mongodb for this project and you are right the part of filter is shown when data intialized is complete

Ankita297 commented 3 years ago

Yes i have not set up mongodb part do i have to do it . Actually i was not able to set it up and it was working fine so i thought it was not necessary .

Namanl2001 commented 3 years ago

Yes it's needed if you want to test the frontend part. It's simple you can google for it. Else you can also put your query on discord channel.

Ankita297 commented 3 years ago

https://user-images.githubusercontent.com/67833077/116291187-ef410d80-a7b1-11eb-8cf8-e4d7118a75c5.mp4

Ankita297 commented 3 years ago

@Namanl2001 Please review it now .

Ankita297 commented 3 years ago

@Namanl2001 @sagar-barapatre changes done Sir .