Closed Ankita297 closed 3 years ago
@sagar-barapatre @Namanl2001 Please review my PR .
Sir i have added the Navbar separtely on both pages because homepage needed parallax effect and 404 page does not need it . But as we use Navbar on app.js it will be render on both page .
Okay this looks fine to me.
@sagar-barapatre According to me its okay but if you want we can change it .
@sagar-barapatre please tell what change do you want ?
I was thinking of something like "Oops, the page you're looking for doesn't exists".
@Namanl2001 @sagar-barapatre is it okay now ?
@Namanl2001 @sagar-barapatre Please review it now .
@Namanl2001 @sagar-barapatre any other changes required ? The mobile view is fine .
@Namanl2001 is it okay now ?
@sagar-barapatre @Namanl2001 is it okay now ?
In the video attached I'm able to see 1st and 2nd point implemented but what about 3rd point mentioned above?
@Namanl2001 Sir i have not changed the part related to filter .
Thus the part of filter is shown when data intialized is complete ?
I guess you haven't setup the mongodb for this project and you are right the part of filter is shown when data intialized is complete
Yes i have not set up mongodb part do i have to do it . Actually i was not able to set it up and it was working fine so i thought it was not necessary .
Yes it's needed if you want to test the frontend part. It's simple you can google for it. Else you can also put your query on discord channel.
@Namanl2001 Please review it now .
@Namanl2001 @sagar-barapatre changes done Sir .
Related Issue
404 page added Closes: #3
Describe the changes you've made
I have added the 404 page
Type of change
What sort of change have you made:
Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Checklist:
Additional Info (optional)
Any additional information you want to give