added admin middleware - Githubissues

Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.

https://guru-jii.herokuapp.com/

MIT License

34 stars 85 forks source link

added admin middleware #198

Closed Subham142 closed 3 years ago

Subham142 commented 3 years ago

Closes: #196

Type of change

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Enhancement in the existing features
[ ] Other

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[x] I have verified/tested my code by running it locally.

Subham142 commented 3 years ago

@Namanl2001 please review

Namanl2001 commented 3 years ago

Looks good. Are you planning to add the admin routes in future PR's? Or in this only?

Subham142 commented 3 years ago

Of course I'll add the routes and controllers.....that's the reason I wanted the middleware to be merged...

I just wanted you to see how and what I'm planning that's why first I just did the schema and the middleware

Namanl2001 commented 3 years ago

Cool! Let's merge this then 👍

Subham142 commented 3 years ago

I'm raising issue for the controller and routes Pleas assign it to me

Subham142 commented 3 years ago

@Namanl2001 would really appreciate if you would change it to a level 2

I had to study the user shcema and backend to customize the admin according to this project

Namanl2001 commented 3 years ago

@Namanl2001 would really appreciate if you would change it to a level 2

I had to study the user shcema and backend to customize the admin according to this project

Sure, No problem