Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
34 stars 85 forks source link

added logo in assets #231

Closed swahim closed 2 years ago

swahim commented 2 years ago

Related Issue

11

Describe the changes you've made

Give a clear description what modifications you have made Added a logo.png file in src > assets

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code NA

Checklist:

Additional Info (optional)

Any additional information you want to give None

github-actions[bot] commented 2 years ago

@swahim Thank you for Opening pull request. We will get back to you as soon as possible. Your patience is greatly appreciated! Thanks! 🥳. PS: Please double check that you linked the corresponding issue.

swahim commented 2 years ago

@Namanl2001 please review this pr

Namanl2001 commented 2 years ago

Are you going to add this logo in the website preview?

also do we need .DS_Store binary files to be merged?

swahim commented 2 years ago

@Namanl2001 i can add the logo but for now I have just added the logo in assets for you. If you say I can add in website preview. Also, .DS_Store is not needed

Namanl2001 commented 2 years ago

please add it and also remove .DS_Store from your changes.