swahim commented 2 years ago

Related Issue

11

Info about the related issue Added logo in website preview Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

Give a clear description what modifications you have made I have added logo in assets folder. Also, made changes in navbar.jsx and style.css

Type of change

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement in the existing features
[ X] Other

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

[X ] My code follows the guidelines of this project.
[ X] I have performed a self-review of my own code.
[ X] I have commented my code, particularly whereever it was hard to understand.
[ X] My changes generate no new warnings.
[ X] I have verified/tested my code by running it locally.

Additional Info (optional)

Any additional information you want to give

github-actions[bot] commented 2 years ago

@swahim Thank you for Opening pull request. We will get back to you as soon as possible. Your patience is greatly appreciated! Thanks! 🥳. PS: Please double check that you linked the corresponding issue.

swahim commented 2 years ago

@Namanl2001 please review this pr. I have added logo in website preview and removed DS_Store file

Namanl2001 commented 2 years ago

can you please add the screenshots here? also I think you have used npm to install the dependencies which resulted in the creation of a new file package-lock.json please delete this file and use yarn. Instructions in readme.

swahim commented 2 years ago

Namanl2001 commented 2 years ago

That was quick. Don't you think that font color of GURU in logo should be of light color. maybe white or any other color of your choice

swahim commented 2 years ago

I have also changed the Ji color so that it fits with the dark background.

Namanl2001 commented 2 years ago

Update this pr and we can merge

swahim commented 2 years ago

@Namanl2001 pr updated

swahim commented 2 years ago

@Namanl2001 so will you merge this pr into master?

github-actions[bot] commented 2 years ago

@swahim Hurray, your PR got merged 🥳. Thanks a bunch. Feel free to take another

swahim commented 2 years ago

@Namanl2001 can you please add hacktoberfest-accepted label in the pr

Namanl2001 commented 2 years ago

done @swahim

swahim commented 2 years ago

thanks @Namanl2001

Namanl2001 / MERN-Gurujii-dev

added logo in website preview #232

Related Issue

11

Describe the changes you've made

Type of change

Mention any unusual behaviour of your code (Write NA if not)

Checklist:

Additional Info (optional)