Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
34 stars 85 forks source link

Unit test in Backend #234

Closed sohan2410 closed 2 years ago

sohan2410 commented 2 years ago

Related Issue

Closes: #20

Describe the changes you've made

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

NA

Checklist:

Additional Info (optional)

Please before merging add Hactoberfest accept and medium/hard label

github-actions[bot] commented 2 years ago

@sohan2410 Thank you for Opening pull request. We will get back to you as soon as possible. Your patience is greatly appreciated! Thanks! 🥳. PS: Please double check that you linked the corresponding issue.

sohan2410 commented 2 years ago

Please add here, the passing tests screenshot from your terminal.

Here is the screenshot yarn test

sohan2410 commented 2 years ago

Also do you know that we can use github actions, to run all the tests for each new PR? Would you like to add this functionality? In this PR?

Do you mean the pre-commit hook?

Namanl2001 commented 2 years ago

Do you mean the pre-commit hook?

Nope, I meant something similar to this: https://medium.com/tomorrowapp/running-end-to-end-tests-with-github-actions-d45b70c032e6

sohan2410 commented 2 years ago

Nope, I meant something similar to this: https://medium.com/tomorrowapp/running-end-to-end-tests-with-github-actions-d45b70c032e6

Can we work on this in different PR as it's not related to the current issue.

Namanl2001 commented 2 years ago

Sure Just remove the last commit you added (hook one)

sohan2410 commented 2 years ago

Sure Just remove the last commit you added (hook one)

done

Namanl2001 commented 2 years ago

sorry, @sohan2410 for the small delay in response.

This PR changes a lot of things, so can you update the NOTE section in readme.md as per changes of this PR, please? https://github.com/Namanl2001/MERN-Gurujii-dev/blob/master/README.md#note--

sohan2410 commented 2 years ago

done

github-actions[bot] commented 2 years ago

@sohan2410 Hurray, your PR got merged 🥳. Thanks a bunch. Feel free to take another

sohan2410 commented 2 years ago

Can u add hard tag please

Namanl2001 commented 2 years ago

Why do you want any tag of that type? Imo hacktober one is enough

sohan2410 commented 2 years ago

Why do you want any tag of that type? Imo hacktober one is enough

For easy, medium and tough we get 10, 20 and 30 points respectively. So based on the PR level you have to add a tag

Namanl2001 commented 2 years ago

done