Namanl2001 / MERN-Gurujii-dev

⭐️ Helps! in finding Tutors.
https://guru-jii.herokuapp.com/
MIT License
34 stars 85 forks source link

Added Contact us page #235

Closed swahim closed 2 years ago

swahim commented 2 years ago

Related Issue

Closes: #[issue number that will be closed through this PR]

128

Describe the changes you've made :

Give a clear description what modifications you have made

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code NA

Checklist:

Additional Info (optional)

Any additional information you want to give I have added nodemon as devDependency and added respective script in package,json file

github-actions[bot] commented 2 years ago

@swahim Thank you for Opening pull request. We will get back to you as soon as possible. Your patience is greatly appreciated! Thanks! 🥳. PS: Please double check that you linked the corresponding issue.

swahim commented 2 years ago

@Namanl2001 please review this pr

Namanl2001 commented 2 years ago

thanks, @swahim , can you please add here (in this PR comment) some screenshots or videos, for the feature you have added?

swahim commented 2 years ago
Screenshot 2021-10-21 at 22 57 57

Added contact us button in navbar which redirects user to contact us page. Below is the contact us page

Screenshot 2021-10-21 at 22 56 59
Namanl2001 commented 2 years ago

Too many buttons on the navbar doesn't look good. Either Move this new option under dropdown menu or try any other idea you have.

swahim commented 2 years ago

@Namanl2001 added contact us in dropdown

Namanl2001 commented 2 years ago

Also how you are trying to send email to me from users email. Is it possible? Without user's credentials

swahim commented 2 years ago

@Namanl2001 yes you are right it is not possible. So what i have done is i have sent self mail and just the user's email id will be visible

swahim commented 2 years ago

So the user is not actually sending the mail. But his message with his email id will be visible in your inbox

swahim commented 2 years ago

@Namanl2001 I have committed changes in pr. This is exactly what I did in my previous project for feedback form. Please review

github-actions[bot] commented 2 years ago

@swahim Hurray, your PR got merged 🥳. Thanks a bunch. Feel free to take another

swahim commented 2 years ago

@Namanl2001 Could you please add a medium or hard tag.