Fix forum index showing topics without view other topics permission

NamelessMC / Nameless

NamelessMC is a free, easy to use & powerful website software for your Minecraft server, which includes a large range of features.

https://namelessmc.com/

MIT License

606 stars 311 forks source link

Closed samerton closed 1 year ago

Derkades commented 1 year ago

please squash when merging, easier to backport :)

samerton commented 1 year ago

please squash when merging, easier to backport :)

Absolutely - I'll always squash if there is >1 commit in the diff, if cherry-picking there is no difference either way

Derkades commented 1 year ago

Squashing is still useful even when a merge request only contains a single commit, because:

the commit title is changed to the PR title, with a reference to the PR number (this means the backport commit will show up in the PR, as a confirmation that the backport has been done)
the date of the commit is updated to be the date of the PR merge
there is no additional merge commit which in my opinion is only clutter in this case