NamelessMC / Nameless

NamelessMC is a free, easy to use & powerful website software for your Minecraft server, which includes a large range of features.
https://namelessmc.com/
MIT License
609 stars 311 forks source link

Fix array for not start with validation #3522

Closed partydragen closed 2 months ago

partydragen commented 3 months ago

The foreach being breaked after the first check, It should only break when result is found

tadhgboyle commented 3 months ago

I think this would be fine to leave or keep, it depends if we want to show all the errors at once (current behaviour?) or one at a time. The former seems better

partydragen commented 3 months ago

I think this would be fine to leave or keep, it depends if we want to show all the errors at once (current behaviour?) or one at a time. The former seems better

What? The issue here is other denied values is never being checked, Only the first one as it break the loop instantly Making them bypass all other denied values

This will still only show 1 error at a time, Same as all other array releated checks