search

Namit2111 / bible-verse-finder

https://bible-verse-finder.vercel.app
GNU General Public License v3.0
23 stars 31 forks source link

changes made #33

Closed rabelmervin closed 1 month ago

rabelmervin commented 1 month ago

Description

This PR updates the project to use the entire Bible for clustering, improving the accuracy and reducing the number of 0% similarity results. Additionally, the data storage has been reorganized, so each book stores its own chapters, which store their own scriptures. The printing of clusters now includes the book name with the verse number (e.g., Matthew 5:38), replacing the manual concatenation of 1 John. ### Related Issues

Closes #1 (Bible clustering issue)

Changes List

✅Updated the clustering to use the entire Bible instead of 1 John.

✅Reorganized data storage for the Gutenberg Bible, structuring by books, chapters, and scriptures.

✅ Modified cluster printing to include the book name attached to the verse number.

Type of Changes

✅Bug fix (fixes an existing issue)

✅Enhancement (improves or changes existing functionality)

Checklist

✅ My code follows the style guidelines of this project.

✅ I have performed a self-review of my code.

✅ I have commented my code, particularly in hard-to-understand areas.

✅ I have made corresponding changes to the issue .

✅My changes generate no new warnings.

✅ New and existing unit tests pass locally with my changes.

vercel[bot] commented 1 month ago

@rabelmervin is attempting to deploy a commit to the namit2111's projects Team on Vercel.

A member of the Team first needs to authorize it.

Namit2111 commented 1 month ago

spam

JustinhSE commented 1 month ago

@Namit2111 this is not spam, he just followed something I asked, which was condense all the commits into 1

JustinhSE commented 1 month ago

@rabelmervin please however put what issue you closed by doing this PR so I can review it

rabelmervin commented 1 month ago

extremely sorry @Namit2111 @JustinhSE i made the changes in https://github.com/rabelmervin/bible-verse-finder/blob/bibleapp/backend/app.py I also made a pr seperately to JustinhSE/bible-verse-finder

JustinhSE commented 1 month ago

No within the template of your pr put what issue it closes @rabelmervin

Namit2111 commented 1 month ago

@rabelmervin check the whole directory you are updating app.py which is not where you should make changes, check the utils.py make your changes there

JustinhSE commented 1 month ago

@rabelmervin as namit said, do make changes only in util and not app.py

rabelmervin commented 1 month ago

Ok I'll make changes in utils.py @Namit2111 @JustinhSE.

JustinhSE commented 1 month ago

Ok I'll make changes in utils.py @Namit2111 @JustinhSE.

Please open another PR and have the correct documentation including the # of the issue you are closing when you do complete that task

rabelmervin commented 1 month ago

Ok @JustinhSE have you seen the changes I made ?