Feature/multiple bible translation

Namit2111 / bible-verse-finder

https://bible-verse-finder.vercel.app

GNU General Public License v3.0

24 stars 32 forks source link

Feature/multiple bible translation #43

Closed fortune710 closed 1 month ago

fortune710 commented 1 month ago

Description

Created a feature to enable bible verse results for multiple translations to improve accessibility.

Related Issues

This PR resolves issue #7

Changes List

[x] Created a centralized location for API implementation
[x] Enabled API response caching for better performance
[x] Refactored some code for better readability

Type of Changes

[x] Enhancement (improves or changes existing functionality)

Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

Output of My Changes

next-build Screenshot 2024-10-19 095124 Screenshot 2024-10-19 095042 Screenshot 2024-10-19 094949

vercel[bot] commented 1 month ago

@fortune710 is attempting to deploy a commit to the namit2111's projects Team on Vercel.

A member of the Team first needs to authorize it.

fortune710 commented 1 month ago

@Namit2111 I couldn't squash the commits as it overwrote the entire commit history because of the merge changes that were made.

JustinhSE commented 1 month ago

@fortune710 for when a version is not available for a translation, is there a way to prevent a user from selecting it? Because for the first image it says it's unavailable for all

fortune710 commented 1 month ago

@JustinhSE Unfortunately there's no way to know ahead of time what translations do not return results for certain bible verses

Namit2111 commented 1 month ago

Why is their uncertainty?

JustinhSE commented 1 month ago

+1 to @Namit2111 comment. Fetches only have positive or negative responses. However, since we are about to move from 1 John, we are going to have to adjust this issue to individual verses having a more button so that you can individually either copy the verse or change that verse translation.

JustinhSE commented 1 month ago

But for now, only determine if the translation would be possible, if not do not display that translation name @fortune710

JustinhSE commented 4 weeks ago

@fortune710 the deadline for this issue to be eligible for a badge is coming up in the next few days. Feel free to work on this and open another PR