Feat/about us page - Githubissues

Namit2111 / bible-verse-finder

https://bible-verse-finder.vercel.app

GNU General Public License v3.0

24 stars 32 forks source link

Feat/about us page #48

Closed d-beloved closed 4 weeks ago

d-beloved commented 4 weeks ago

Description

This PR adds the About Us page to the app, showing the "Number of commits in the repo", "total number of contributors", and the "lines of code"

Related Issues

Closes #23 (issue)

Changes List

[x] Adds the "about" route
[x] Creates functions to get the statistics from the GitHub REST API
[x] Makes the About us page responsive
[x] Add a button to star the repository on GitHub

Type of Changes

[x] Enhancement

Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

vercel[bot] commented 4 weeks ago

@d-beloved is attempting to deploy a commit to the namit2111's projects Team on Vercel.

A member of the Team first needs to authorize it.

d-beloved commented 4 weeks ago

@Namit2111 and @JustinhSE this PR is up for review.

@Namit2111 please help check what the error is on Vercel. I have run npm run build for the production build on my terminal, and everything runs smoothly. Vercel is likely catching another issue online. Screenshot 2024-10-28 at 15 40 20

JustinhSE commented 4 weeks ago

@d-beloved can you cd outside of the about us section and run npm run build in the frontend directory just to make sure?

d-beloved commented 4 weeks ago

@d-beloved can you cd outside of the about us section and run npm run build in the frontend directory just to make sure?

I've done that @JustinhSE it builds without errors on the main branch.

JustinhSE commented 4 weeks ago

Okay great, Namit needs to review it so it can be merged

On Mon, Oct 28, 2024 at 11:11 AM Ayodeji Moronkeji @.***> wrote:

@d-beloved https://github.com/d-beloved can you cd outside of the about us section and run npm run build in the frontend directory just to make sure?

I've done that @JustinhSE https://github.com/JustinhSE it builds without errors on the main branch.

— Reply to this email directly, view it on GitHub https://github.com/Namit2111/bible-verse-finder/pull/48#issuecomment-2441866471, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGMUCULY47NX3A2OQXO2YDZ5ZH3BAVCNFSM6AAAAABQXPWQMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRHA3DMNBXGE . You are receiving this because you were mentioned.Message ID: @.***>

Namit2111 commented 4 weeks ago

hey @d-beloved Can you make a Readme.md in frontend folder explaining the current working structure of the app!?

d-beloved commented 3 weeks ago

hey @d-beloved Can you make a Readme.md in frontend folder explaining the current working structure of the app!?

I will add the Readme after the second About Us issue (#24) has been done