search

Namit2111 / bible-verse-finder

https://bible-verse-finder.vercel.app
GNU General Public License v3.0
24 stars 32 forks source link

feat(docs):Upload ESV.pdf and KJV.pdf translations to backend folder #52

Closed torok839098 closed 3 weeks ago

torok839098 commented 3 weeks ago

Dear Versify Team, I had to individually upload the pdfs due to size. These include ESV and KJV translations.

Thank you so much and God Bless you all!

vercel[bot] commented 3 weeks ago

@torok839098 is attempting to deploy a commit to the namit2111's projects Team on Vercel.

A member of the Team first needs to authorize it.

Namit2111 commented 3 weeks ago

what is this about?

JustinhSE commented 3 weeks ago

@Namit2111 this doesn't have relation to any issues

torok839098 commented 3 weeks ago

Dear Bible Finder team, I want some clarification on how it's considered spam. This is my first year of joining Hacktoberfest as well as my first time learning about contribution to open source. I'm a career switcher from healthcare so the concepts of what is considered spam is still new to me. As I recall I saw this on your Discord:

Welcome to the Bible Verse Finder! This repository contains code to parse and analyze the Bible. We want your help in adding features and improving this app!

We are looking for contributors to work on some of the following issues:

API integration - multiple bible translations ML/Web Dev- make a Gemini Chatbot Backend - User Authentication/Database integration Convert the HTML to Next.js framework (need more people to help out here)

Let us know if you are interested!

So, perhaps I misread it. My thought process was that I decided to upload more pdfs of different versions of the bible which could be beneficial with the API or see how different versions show up for certain verses. Like you can look up key words and it shows up verses and it's labeled depending on the bible version. I would appreciate guidance on how to make it seem less 'spam' that way I understand for next projects and make my contributions to your project more useful.

Thank you so much!

Namit2111 commented 3 weeks ago

Hi @torok839098 the issues with this PR were

  1. No issues was created before addressing this PR
  2. There was no discussion stating we need uploads of new books as PDF