search

Namo2 / InPlayerEpisodePreview

A Jellyfin plugin for the web and client version, which displayes an episode list inside the player
MIT License
125 stars 7 forks source link

Feature request: Show IMDb score #18

Closed Gauvino closed 5 months ago

Gauvino commented 5 months ago

Show the IMDb score in episode preview (and also rotten tomatoes if possible)

Namo2 commented 5 months ago

I will release a new version in a minute. Getting the rating from other databases is a bit tricky, For now, I just added the community rating which Jellyfin uses. I guess it queries it from some other place (probably the metadata provider for the show) but I am not sure about that

Gauvino commented 5 months ago

First of all thanks for being this fast and the implementation is really cleaned but I have a question, wouldn't it be better to put the information like at the bottom (look at the screenshot below), to have a more compact design? q2THNVMQN7

Namo2 commented 5 months ago

Right. Maybe I will. I try to stay as close as possible to the way Jellyfin has implemented things. Took this section as my reference point from the dashboard of an episode: image

I also plan to add some settings. Maybe this position will be one of them. If you have any other ideas let me know

Gauvino commented 5 months ago

No problem, thanks for all and I will let you know if I have any ideas !

Namo2 commented 5 months ago

@Gauvino btw i have seen, that jellyfin has rotten (and fresh?) tomato ratings for movies. Is this also a thing for shows and a settings issue on my site? If yes i could add those ratings quite easily for the next release

Gauvino commented 5 months ago

@Gauvino btw i have seen, that jellyfin has rotten (and fresh?) tomato ratings for movies. Is this also a thing for shows and a settings issue on my site? If yes i could add those ratings quite easily for the next release

chrome_aWJrsXq93Y This all the ratings I have on jellyfin, only imdb and rotten, what is fresh ??

And not every show's as the rottentomatoes, in exemple for me on some anime i don't have the rotten one: Exemple: chrome_Tnpvqch0bz

And yes, i think it's a good idea to add it !

Namo2 commented 5 months ago

image This is marked as mediaInfoCriticRatingRotten

image While this is marked as mediaInfoCriticRatingFresh

So yeah, i will add both of them, just never saw any of that in the shows i have

Namo2 commented 5 months ago

Do you have a list or 1-2 suggestions of shows/anime which have this kind of rating? So I can test it after I make the changes?

Gauvino commented 5 months ago

Ok so after investigation, I couldn't find any shows with the rotten score idk why

Namo2 commented 5 months ago

Well, i could add them anyways, so if jellyfin should ever decide to display them for shows, they should be there without any further update