search

NancyFx / Nancy.Bootstrappers.Ninject

Nancy boostrapper for the Ninject container
MIT License
17 stars 25 forks source link

Set ChildKernel's service scope to singleton by default #11

Closed scott-xu closed 10 years ago

scott-xu commented 10 years ago

Any objections please?

thecodejunkie commented 10 years ago

Hoping to review this and some other pending pull-requests later tonight

thecodejunkie commented 10 years ago

Much appreciated @scott-xu welcome to the Nancy contributor club! :)

scott-xu commented 10 years ago

Thank you. BTW, I think we can delete FactoryModule as well because Ninject has a official factory extension https://github.com/ninject/ninject.extensions.factory

scott-xu commented 10 years ago

I think I can send a new pull request later

thecodejunkie commented 10 years ago

@scott-xu happy to take a PR and look at it =) The less code we have to maintain the better :)

scott-xu commented 10 years ago

@thecodejunkie PR has had been sent https://github.com/NancyFx/Nancy.Bootstrappers.Ninject/pull/12