search

NancyFx / Nancy.MSOwinSecurity

Nancy Owin Security integration
MIT License
30 stars 14 forks source link

Support for Nancy v2 #17

Closed ravenpride closed 5 years ago

ravenpride commented 5 years ago

This PR contains changes to support Nancy v2.

I've raised the minimum required .NET framework to 4.5.2 and updated the Nuget package references accordingly. The only thing is that 2 unit tests fail, but the returned result of the tested method seems ok for me. Could you please have a look at it?

Note: This PR breaks compatibility with previous versions as the library now references Nancy v2 components. It will not work with Nancy v1, so I added a note into README.md to inform users.

ravenpride commented 5 years ago

I've just noticed that the only tag in this repository is v1.0.0. On nuget.org there is a package with version v2.0.0 made by @damianh, but - as far as I can see - this repository has been updated to include his changes (more and newer commits and contributions from @damianh).

Hm, is this repository the official one for the Nancy.MSOwinSecurity package or is it another one? It's a bit confusing. Could someone enlighten me, please? ;-)

Thank you in advance.

ravenpride commented 5 years ago

Could someone from the development team give a short statement about the PR, please?

NancyFx is available in version 2, but this package is not - so this package has become useless in NancyFx v2. Please consider accepting the PR to make it work again.

damianh commented 5 years ago

V3 Will be on nuget.org shortly https://www.nuget.org/packages/Nancy.MSOwinSecurity/3.0.0