Nandaka / NijieDownloader

nijie.info downloader
http://nandaka.devnull.zone/
60 stars 8 forks source link

Batch download stops at each image due to DateTime error #58

Open ReisenII opened 6 years ago

ReisenII commented 6 years ago

Every time I try to batch, for some (not all) image sets, the app downloads one image and then stop giving me this error. Translates as "String not recognized as valid DateTime"

I can download still, but I have to restart the whole batch for each image.

I'm using normal Gregorian calendar as system time.

immagine

Changing the option "Use server time" doesn't fix the problem

2

Older image sets and single images download fine.

Nandaka commented 6 years ago

Can you upload the log file (e.g. Batch Download on 2018-06-17.txt) in the application folder?

I tried to download member id: 153227 and it working as expected.

ReisenII commented 6 years ago

The file is just a bunch of file locations.

Batch Download on 2018-06-17.txt

Halfway I tried to move the destination folder, but that didn't change anything.

Nandaka commented 6 years ago

Ya, I give you the wrong filename, should be log-yyyy-mm-dd.txt (e.g log-2018-06-17.txt) for the actual log file.

ReisenII commented 6 years ago

I freshly downloaded and unpacked the whole program and tried to download the same user until the said error happened a couple of times, here's the log

log-2018-06-18.txt

I couldn't find the log file for yesterday's attempt to batch download, I hope this is enough. I may also add I tried to download a different user (99492) and it gave me no errors at all.

Nandaka commented 6 years ago

Can you try to replace the NijieDownloader.Library.dll and upload the log file again? I add additional logging to check the actual datetime string the server sent.

NijieDownloader.Library.zip

ReisenII commented 6 years ago

Sure thing

I redownloaded the 7z, unpacked, replaced the dll you asked for and tried to run the batch a couple of times like the last time.

log-2018-06-20.txt

Nandaka commented 6 years ago

weird, it failed to parse these dates: image

not sure why yet, worst case I need to suppress this.

Nandaka commented 6 years ago

Can you try one? NijieDownloader.Library.zip

ReisenII commented 6 years ago

(As before, redownloaded the 7z, unpacked, replaced the dll file) The batch no longer stops and I could download the whole user id 153227 in one go, although the single downloads felt slower than usual.

The log log-2018-06-21.txt

Nandaka commented 6 years ago

yeah, not sure why it still failed to parse the datetime, it looks like the correct format to me. image

EDIT: might need to use CultureInfo.InvariantCulture in the dll, I'll create new dll later

ReisenII commented 6 years ago

Looks like the errors are gone with english as system language log-2018-06-21.txt For reference, I have my system in italian.

Nandaka commented 6 years ago

ok, I'll try to compile the dll with CultureInfo.InvariantCulture and upload it here.

Nandaka commented 6 years ago

Try this one? NijieDownloader.Library.zip

ReisenII commented 6 years ago

Looks like it works as intended now, no errors and a quick uninterrupted download log-2018-06-22.txt