Nandaka / PixivUtil2

Download images from Pixiv and more!
http://nandaka.devnull.zone/
BSD 2-Clause "Simplified" License
2.3k stars 250 forks source link

Downloading from fanbox user that is active on fanbox but suspended on pixiv halts the program and asks for name #1117

Closed Zekira closed 1 year ago

Zekira commented 2 years ago

Prerequisites

Description

When I try to download from a user on fanbox that is suspended on pixiv, I will be asked for name, even if I already typed it before. The functionality seems to be that this should only happen once per user since it should now be on the database, but that doesn't seem to be case and I keep getting that halt for the same user:

Similar to this over a year old issue which was apparently fixed, but is still happening for me: https://github.com/Nandaka/PixivUtil2/issues/873

image

Is it possible to just get the name from the fanbox data instead of the pixiv data?

Steps to Reproduce

  1. Use any fanbox command that will point to an active use in Fanbox but suspended in pixiv.
  2. Input name when program asks. Not sure if it makes a difference but I input simple Hiragana here
  3. Let it finish
  4. Do same command for same user
  5. Name is still asked

Expected behavior: Program halts and asks for name

Actual behavior: Name should not be asked; preferrably the name should be retrieved from fanbox data instead of pixiv data

Log file: pixivutil.log

Versions

20220311-beta3 You can get this information from executing PixivUtil2.py --help. Latest version available in https://github.com/Nandaka/PixivUtil2/releases

Nandaka commented 2 years ago

%artist% is not the same as the username %member_token%. I'm not sure if the name in Fanbox is always the same with the name in Pixiv or not as I don't use fanbox

Nandaka commented 2 years ago

hmm, it is being validated because the fanbox filenameformats have %artist% or %member_token%. https://github.com/Nandaka/PixivUtil2/blob/master/PixivFanboxHandler.py#L27-L41

Maybe I can add new format called %fanbox_name% and %fanbox_creator_id%' taken frombody.user.nameandbody.creatorid` instead? image