NanderTGA / msgroom-orm

A MsgRoom client.
https://nandertga.github.io/msgroom-orm/
MIT License
4 stars 0 forks source link

feat: protect users against ReDoS #145

Open NanderTGA opened 11 months ago

NanderTGA commented 11 months ago

ReDoS vulnerabilities are a serious problem and people using regex prefixes could fall victim to this. I want to protect people against this by checking for ReDoS vulnerabilities in the background using recheck.

It does add an extra dependency though. Do or don't?

nolanwhy commented 11 months ago

yes, but if you can, do something so we can disable it in the Client, like new Client("testbot", [ "e" ], { recheck: false })

NanderTGA commented 11 months ago

yes, but if you can, do something so we can disable it in the Client, like new Client("testbot", [ "e" ], { recheck: false })

Yeah, I was planning to do that.