search

NanderTGA / msgroom-orm

A MsgRoom client.
https://nandertga.github.io/msgroom-orm/
MIT License
4 stars 0 forks source link

fix: implement a proper way to get the sessionID #89

Closed NanderTGA closed 1 year ago

NanderTGA commented 1 year ago

This is a follow-up issue to #34. In 3 months time the msgroom server has seemingly changed a bit. For example, I recall seeing a werror in the console sent by the server saying You are doing this too much - please wait a while ago. I also recall seeing another bot written in python which seemingly got the session ID from an event. I need to investigate this further because the hack to get the sessionID is pretty janky and barely works. Turns out I didn't account for people getting the session ID when blockSelf is off.

Thanks to Kelbaz for reporting the issue.

NanderTGA commented 1 year ago

The auth-complete event indeed returns the sessionID now. Thanks to the96thBot for discovering this! Fix refactor will be committed soon.

msgroom-js-semantic-release[bot] commented 7 months ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: