search

NanderTGA / msgroom-server

A custom, better msgroom server.
GNU Affero General Public License v3.0
1 stars 1 forks source link

Newlines trimming #2

Closed RixInGithub closed 5 months ago

RixInGithub commented 5 months ago

When one of my bots try to send a message with two newlines (\n\n), both of them get trimmed. Not a space appears instead, just nothingness. Something like

text before newlinestext after newlines

I'd really like if this bug were to be patched. I even tried using \r\n but it still did the same. Haven't tried using just \r, but I guess it'll turn out the same. Is this a problem from MarkdownIt? (I noticed your project uses MarkdownIt) I don't know.

But my bots will look better if you patched this bug. Please?

EDIT: Same bug after using \r instead of \n.

RixInGithub commented 5 months ago

@NanderTGA (urgent(-ish(?)) issue)

RixInGithub commented 5 months ago

Added a test for wawaOS for Nander to see the bug in practice.

EDIT: Source code proof

NanderTGA commented 5 months ago

I think it's some problem related to markdown-it. It normally surrounds each paragraph with <p>, which makes messages look too big, and there's no good way to turn it off.

Sorry for not replying earlier, I forgot to finish typing this message. Anyway I think I have a potential solution.

RixInGithub commented 5 months ago

I think it's some problem related to markdown-it. It normally surrounds each paragraph with <p>, which makes messages look too big, and there's no good way to turn it off.

Sorry for not replying earlier, I forgot to finish typing this message. Anyway I think I have a potential solution.

  1. Just as I thought, it's a problem of Markdown-it.
  2. Accepting apology...
    ################ 100%Apology accepted!
  3. I'm excited to see the patch for this bug. #SquattingBugsForEternities!
RixInGithub commented 5 months ago

@TheDude53, being the awesome Dude he is (Get it? The Dude?) shared an issue. => https://github.com/markdown-it/markdown-it/issues/211

RixInGithub commented 5 months ago

Patched! #SquattingBugsForEternities

TheDude53 commented 5 months ago

@TheDude53, being the awesome Dude he is (Get it? The Dude?) shared an issue. => markdown-it/markdown-it#211

Glad I could help!

RixInGithub commented 5 months ago

@TheDude53, being the awesome Dude he is (Get it? The Dude?) shared an issue. => markdown-it/markdown-it#211

Glad I could help!

:D