Nandulucky / core-plot

Automatically exported from code.google.com/p/core-plot
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

CPTBorderedLayer renders offscreen #547

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
setMasksToBorder: uses self.mask = maskLayer which makes it "yellow" in the 
simulator/device and means a serious performance hit, says Josh Shaffer 
(@joshshaffer on Twitter).

What steps will reproduce the problem?

I guess just add a Core Plot to a UIView, no? :-) Can you reproduce it.

What is the expected output? What do you see instead?

I'm expect to perform better, so it means not use a mask on the layer :) 
Commenting that one self.mask = ... my code still works (probably because I'm 
not using borders for example).

What version of the product are you using? On what operating system?

https://github.com/djw/core-plot/commit/e3f2501acedefa3910c26c150fa0d722c9eea233

Please provide any additional information below.

See 
https://groups.google.com/forum/?fromgroups=#!topic/coreplot-discuss/Lg5P83fwGeQ

Original issue reported on code.google.com by m...@stuffmc.com on 13 Jun 2013 at 12:39

GoogleCodeExporter commented 9 years ago

Original comment by eskr...@mac.com on 14 Jun 2013 at 1:07

GoogleCodeExporter commented 9 years ago

Original comment by eskr...@mac.com on 16 Jun 2013 at 10:07

GoogleCodeExporter commented 9 years ago
Anything new on this? :)

Original comment by m...@stuffmc.com on 19 Jun 2013 at 3:14

GoogleCodeExporter commented 9 years ago
Working on it. I have an idea how to fix it, but I haven't finished 
implementing and testing the fix yet.

Original comment by eskr...@mac.com on 19 Jun 2013 at 11:44

GoogleCodeExporter commented 9 years ago
After further investigation, I am unable to remove the layer mask from the plot 
area frame. It is required in some cases to get the desired clipping behavior 
for axis labels and other parts of the graph.

I wasn't able to find an efficient way to dynamically manage the mask so it is 
used only when needed, so for now, you'll need to manage the mask manually.

When the mask is not needed, set masksToBorder to NO on the plot area frame. I 
updated all of the example apps to remove the mask when it is not needed.

Original comment by eskr...@mac.com on 28 Jun 2013 at 1:27