NangoHQ / nango

A single API for all your integrations.
https://www.nango.dev
Other
4.33k stars 382 forks source link

fix(run): use SyncConfig instead of NangoConfig #2375

Closed bodinsamuel closed 1 week ago

bodinsamuel commented 2 weeks ago

Describe your changes

Contributes to https://linear.app/nango/issue/NAN-1261/pass-json-schema-to-runner

I need to pass json_schema that will live inside _sync_configs, instead of adding a new param I decided to group the params that were belonging to SyncConfig object (and also remove the need for loading NangoConfig locally). nb: this SyncConfig was already fetched from the inside the method which was thing less flexible for CLI and testing.

linear[bot] commented 2 weeks ago

NAN-1261 Pass JSON schema to runner

bodinsamuel commented 2 weeks ago

Can I have you review on this @khaliqgant? thanks ☺️