I need to pass json_schema that will live inside _sync_configs, instead of adding a new param I decided to group the params that were belonging to SyncConfig object (and also remove the need for loading NangoConfig locally). nb: this SyncConfig was already fetched from the inside the method which was thing less flexible for CLI and testing.
Add required parameter syncConfig: SyncConfig
The side effects are minimal but I managed to reduce/remove a lot of code inside run() so the main change are in run.service.ts
Remove default export and use SyncRunService class name
Describe your changes
Contributes to https://linear.app/nango/issue/NAN-1261/pass-json-schema-to-runner
I need to pass json_schema that will live inside
_sync_configs
, instead of adding a new param I decided to group the params that were belonging to SyncConfig object (and also remove the need for loading NangoConfig locally). nb: this SyncConfig was already fetched from the inside the method which was thing less flexible for CLI and testing.Add required parameter
syncConfig: SyncConfig
The side effects are minimal but I managed to reduce/remove a lot of code insiderun()
so the main change are in run.service.tsRemove default export and use SyncRunService class name