search

NannyML / nannyml

nannyml: post-deployment data science in python
https://www.nannyml.com/
Apache License 2.0
1.81k stars 129 forks source link

Relax SQLModel deps version to >=0.0.8,<0.1.0 #383

Open cristiangreco94 opened 2 months ago

cristiangreco94 commented 2 months ago

Motivation: describe the problem to be solved Current SQLModel version is set to ^0.0.8. This translates to >=0.0.8 <0.0.9-0 due to the Caret special treatment of 0s. SQLModel 0.0.8 constraints SQLAlchemy to be <2, making NannyML not compatible with projects using newer versions of SQLAlchamy.

Describe the solution you'd like I would change SQLModel versioning to be at the very least >=0.0.8,<0.1.0. Current version of SQLModel is 0.0.18 and it fully supports SQLAlchemy above or below 2.x.y, so not a problem for backcompatibility. I also tested it locally and no NannyML unit-test was broken by upgrating SQLModel to 0.0.18.

nnansters commented 2 weeks ago

Yup, sorry for being late with the dependency bumps on this one. Your suggestion was indeed totally valid, thanks for double checking.

I've updated the dependency in #401 , feel free to check and make any remarks you might have!