Nano77 / gdm3setup

An interface to configure GDM3, autologin options and change Shell theme
GNU General Public License v2.0
101 stars 29 forks source link

Handle multiple setting assignment on same line #12

Closed fredrik-hammar closed 12 years ago

fredrik-hammar commented 12 years ago

Hi!

I ran into the same problem others at AUR are having at https://aur.archlinux.org/packages.php?ID=50232, that gives the following stack trace.

Traceback (most recent call last):
File "/usr/bin/gdm3setup.py", line 737, in <module>
    MainWindow().show()
File "/usr/bin/gdm3setup.py", line 404, in __init__
    self.get_gdm()
File "/usr/bin/gdm3setup.py", line 484, in get_gdm
    self.FALLBACK_LOGO = unquote(get_setting("FALLBACK_LOGO",settings))
File "/usr/bin/gdm3setup.py", line 709, in get_setting
    return value
UnboundLocalError: local variable 'value' referenced before assignment

The problem is that multiple settings with the same value can be set on same line. In this case: LOGO_ICON=FALLBACK_LOGO=''. I'm guessing you can't reproduce it yourself so I tried fixing it myself.

I'm new to GitHub but I have been wanting to try it out for a while now and this seemed like a nice opportunity. Please don't hesitate to tell me if I did something wrong.

Nano77 commented 12 years ago

multiple setting assignment on same line is caused by a bug in get_gdm.sh

Nano77 commented 12 years ago

the bug in get_gdm.sh are now corrected

fredrik-hammar commented 12 years ago

Ah, I see. I did not investigate where the values were from. Thanks for fixing it properly.