NanoAdblocker / NanoCore

An adblocker
GNU General Public License v3.0
457 stars 22 forks source link

consider a flush cache and add scroll bar button #106

Closed jspenguin2017 closed 6 years ago

jspenguin2017 commented 6 years ago

I think a flush (in memory browser) cache button in the dashboard can be useful. Also, an add scroll bar button to popup panel sounds good as well.

elypter commented 6 years ago

what do you mean by "add scroll bar button"? for the website or for the popup panel?

jspenguin2017 commented 6 years ago

Clearly for website.

jspenguin2017 commented 6 years ago

https://github.com/NanoAdblocker/NanoCore/pull/107 5 buttons can fit on a row, but since we are adding bug reporter soon, I'll make room for it now. I'm not sure which icon to use for force enable scroll. All available icons are here: https://fontawesome.com/v4.7.0/icons/

image image

elypter commented 6 years ago

cant you use icons from other sources? i think something like this would be easier to understand: https://ixquick-proxy.com/do/show_picture.pl?l=deutsch&rais=1&oiu=https%3A%2F%2Fcdn3.iconfinder.com%2Fdata%2Ficons%2Flinecons-layout%2F512%2Fscroll_bar-512.png&sp=1098ff5f6de3f9146d8961869815d84f

https://ixquick-proxy.com/do/show_picture.pl?l=deutsch&rais=1&oiu=https%3A%2F%2Fwww.iconexperience.com%2F_img%2Fo_collection_png%2Fgreen_dark_grey%2F512x512%2Fplain%2Fscroll_bar_vertical.png&sp=d73c8fb98395939e7e0948bad8a36235

https://ixquick-proxy.com/do/show_picture.pl?l=deutsch&rais=1&oiu=https%3A%2F%2Fcdn1.iconfinder.com%2Fdata%2Ficons%2Fuser-interface-11%2F100%2F34-512.png&sp=33213dab63b384d50c7714ef27a51b42

https://ixquick-proxy.com/do/show_picture.pl?l=deutsch&rais=1&oiu=https%3A%2F%2Fimage.freepik.com%2Ffree-icon%2Fscroll-bar_318-47541.jpg&sp=be04e3a3030a768e12f0dfeba7f43aad

if it has to be one from the list i would prefer the arrows-v icon

elypter commented 6 years ago

if you add this then you should also add a force zoom button or make a combined function button. i made a userscript to allow zoom on all sites but it doesnt seem to work and i dont know how to debug userscripts on mobile. maybe it still helps you a bit https://greasyfork.org/de/scripts/36755-freezoom

another thing would be force enable right click and copy. there is a popular userscript for this https://greasyfork.org/de/scripts/23772-absolute-enable-right-click-copy

jspenguin2017 commented 6 years ago

I don't want the icon to be an image, it doesn't scale well on different devices.

For zoom, I think the meta is parsed when it is first seen and changing it won't do anything. Most browsers have an option to ignore no zoom directive though.

For right click and copy, we can look at that later, but not in this issue. I created a new issue for that: https://github.com/NanoAdblocker/NanoCore/issues/109

jspenguin2017 commented 6 years ago

Can someone alert me when gorhill uploads 1.15.0 to web store?

reunicorn commented 6 years ago

Sure, I'll let you know when I see 1.15.0 on Chrome's web store :) BTW I assume you already know it's been uploaded to the Firefox Add-on Page?

jspenguin2017 commented 6 years ago

Oh wow, I totally missed that. Thx, I'll publish new version now.

reunicorn commented 6 years ago

Good to hear! No problem.

jspenguin2017 commented 6 years ago

gorhill put the tag on the wrong commit... I pulled more than I wanted... Hum... hopefully it won't blow things up.

jspenguin2017 commented 6 years ago

I question the usefulness of this... It's too small, and you can't pop it off like the debugger. I'll keep it disabled for now.

![image](https://user-images.githubusercontent.com/7283682/35763225-ac24358a-0864-11e8-9a21-1ee758303204.png) ![image](https://user-images.githubusercontent.com/7283682/35763234-c4cfed4a-0864-11e8-8b24-4552a4eb53a4.png)
jspenguin2017 commented 6 years ago

I got the binaries built, but the Edge version is having some technical difficulties, I'll iron it out later. Looks like MS isn't reviewing my extension any time soon anyway. I'll use the new builds a bit to make sure nothing's on fire.

jspenguin2017 commented 6 years ago

OK, now back to topic... Where should I place the flush cache button? If I put it in the dashboard the user will have to jump back to click it. I'm not sure how should I design it if I put it in the popup panel. As there is the other refresh button.

jspenguin2017 commented 6 years ago

Edge build is fixed.

jspenguin2017 commented 6 years ago

I'm not sure how useful a flush all cache button will be. I exposed the refresh button which allows you to refresh the active page while bypassing cache. I'll see how this goes, I can always add flush all cache button on the side if it turns out to be needed. https://github.com/NanoAdblocker/NanoCore/pull/117